Skip to content

SNARK-friendly STM: Re-organize modules #2804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

SNARK-friendly STM: Re-organize modules #2804

wants to merge 4 commits into from

Conversation

@curiecrypt
Copy link
Collaborator

@curiecrypt curiecrypt commented Nov 20, 2025

Content

This PR includes re-organization of the modules in mithril-stm to make the library ready for SNARK integration.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • All check jobs of the CI have succeeded
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)
    • Add ADR blog post or Dev ADR entry (if relevant)
    • No new TODOs introduced

Comments

Issue(s)

Relates to #2793

@github-actions
Copy link

github-actions bot commented Nov 20, 2025 •
edited
Loading

Test Results

    4 files  ±0    168 suites  ±0   23m 4s ⏱️ -50s
2 214 tests ±0  2 214 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 905 runs  ±0  6 905 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 1de6684. ± Comparison against base commit 2943337.

This pull request removes 23 and adds 23 tests. Note that renamed tests count towards both. 
mithril-stm ‑ bls_multi_signature::proof_of_possession::tests::golden::golden_conversions
mithril-stm ‑ bls_multi_signature::signature::tests::golden::golden_conversions
mithril-stm ‑ bls_multi_signature::signing_key::tests::golden::golden_conversions
mithril-stm ‑ bls_multi_signature::tests::batch_verify
mithril-stm ‑ bls_multi_signature::tests::serialize_deserialize_sk
mithril-stm ‑ bls_multi_signature::tests::serialize_deserialize_vk
mithril-stm ‑ bls_multi_signature::tests::test_aggregate_sig
mithril-stm ‑ bls_multi_signature::tests::test_eval_sanity_check
mithril-stm ‑ bls_multi_signature::tests::test_infinity_sig
mithril-stm ‑ bls_multi_signature::tests::test_infinity_vk
…

mithril-stm ‑ membership_commitment::merkle_tree::tree::tests::test_bytes_batch_path
mithril-stm ‑ membership_commitment::merkle_tree::tree::tests::test_bytes_path
mithril-stm ‑ membership_commitment::merkle_tree::tree::tests::test_bytes_tree
mithril-stm ‑ membership_commitment::merkle_tree::tree::tests::test_bytes_tree_commitment
mithril-stm ‑ membership_commitment::merkle_tree::tree::tests::test_bytes_tree_commitment_batch_compat
mithril-stm ‑ membership_commitment::merkle_tree::tree::tests::test_create_batch_proof
mithril-stm ‑ membership_commitment::merkle_tree::tree::tests::test_create_invalid_batch_proof
mithril-stm ‑ membership_commitment::merkle_tree::tree::tests::test_create_invalid_proof
mithril-stm ‑ membership_commitment::merkle_tree::tree::tests::test_create_proof
mithril-stm ‑ signature_scheme::bls_multi_signature::proof_of_possession::tests::golden::golden_conversions
…

♻️ This comment has been updated with latest results.

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 20, 2025
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@curiecrypt